Skip to content

feature: AutoGluon 0.4.2 image_uris support #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2022
Merged

feature: AutoGluon 0.4.2 image_uris support #3157

merged 1 commit into from
Jun 6, 2022

Conversation

gradientsky
Copy link
Contributor

Description of changes:
Added image_uri metadata for AutoGluon 0.4.2

Testing done:
tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: eaf9b20
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: eaf9b20
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #3157 (eaf9b20) into master (f14a4f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3157   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         200      200           
  Lines       17391    17391           
=======================================
  Hits        15587    15587           
  Misses       1804     1804

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14a4f5...eaf9b20. Read the comment docs.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: eaf9b20
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: eaf9b20
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: eaf9b20
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni
navinsoni suggested changes Jun 6, 2022
View reviewed changes
tests/unit/sagemaker/image_uris/test_autogluon.py
if (
scope == "inference"
and processor == "gpu"
and version in ["0.3.1", "0.3.2", "0.4.0", "0.3"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need "0.4.2" as well here with "0.4.0

Copy link
Contributor Author

@gradientsky gradientsky Jun 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is correct: inference GPU containers were introduced in 0.4.2; the earlier releases had no GPU containers, thus this logic in the test to ensure that the old containers fail on attempt to use GPU, while '0.4.2' and '0.4' works and generates correct URI.

@navinsoni navinsoni changed the title feat: AutoGluon 0.4.2 image_uris support feature: AutoGluon 0.4.2 image_uris support Jun 6, 2022
@navinsoni navinsoni merged commit 858e943 into aws:master Jun 6, 2022
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Aug 8, 2022
@gradientsky @jerrypeng7773
feature: AutoGluon 0.4.2 image_uris support (aws#3157)
cc51c1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navinsoni navinsoni navinsoni approved these changes

@BasilBeirouti BasilBeirouti BasilBeirouti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gradientsky @sagemaker-bot @codecov-commenter @navinsoni @BasilBeirouti